Normalize Ligature Caret List #1227
Merged
+261
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LigCaretList in GDEF is another subtable that contains values that may have associated variation data, which means that it is highly susceptable to minor differences related to the sort order of the item variation store. This adds logic for generating a normalized representation of this tables contents, simililar to how we handle marks & kerns.
rsheeter
reviewed
Jan 30, 2025
resources/scripts/ttx_diff.py
Outdated
| if table == "gpos": | ||
| out_path = font_file.with_suffix(".markkern.txt") | ||
| elif table == "gdef": | ||
| out_path = font_file.with_suffix(".norm_gdef.txt") |
There was a problem hiding this comment.
nit: I like the idea of the normalizer outputs having a consistent naming pattern. Why do we call gpos markkern and gdef norm_gdef instead of something consistent?
There was a problem hiding this comment.
I'd avoided this because I thought it would screw up the next crater run (since the old run would produce the first name, and the second would produce the new name, and they wouldn't know about each other) but this filename isn't actually the name that we use in crater so it should be fine, can change markkern to norm_gpos.
And delete this subtable as well as the ItemVariationStore from the GDEF table. We now normalize everything that otherwise depended on the GDEF VarStore, so we can ignore it during diffing.
cmyr
force-pushed
the
normalize-lig-carets
branch
from
68bcbb2 to
10911df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This table is a lot like mark/kern rules, in that it contains scalar values that can have variations applied. Like with those structures, this is an excellent case for normalization, since it means we can ignore differences related to the order in which deltas are stored.
This patch adds the ability to normalize this table, and updates ttx_diff to do that and to remove it as well as the VarStore from GDEF.
This gives us another +20 or so on crater.